Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track debugging sessions until csdevkit is initialized #6480

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

isadorasophia
Copy link
Contributor

Issue
When using C# dev kit with C# extension, there was a bug that hot reload might not initialize on the first debugging session. This happened due to a race condition that the 'launch' command is fired before the C# dev kit finishes initializing, so no brokeredServicePipeName is passed to the debugger.

Fix
Starts tracking the debugging session until C# dev kit is initialized. If there is an existing debugging session, this sends a custom initializeBrokeredServicePipeName request with the pipe name.

@isadorasophia isadorasophia requested a review from a team as a code owner October 3, 2023 20:31
Copy link
Contributor

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@isadorasophia isadorasophia merged commit e91e3f0 into main Oct 11, 2023
8 checks passed
@isadorasophia isadorasophia deleted the dev/isgarcia/delayed-csdevkit-init branch December 19, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants