Add integration test for .runsettings in unit tests #6336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Sep 11, 2023
|
|
||
| async function setConfigurationAndWaitForObserver<T>(configuration: string, value: T): Promise<void> { | ||
| const changed = new Promise<void>((resolve, _) => { | ||
| vscode.workspace.onDidChangeConfiguration((e) => { |
There was a problem hiding this comment.
incredibly annoyingly, optionProvider.GetLatestOptions() does not actually read the latest options. It instead uses whatever the observable last triggered with. This is extremely racy, so I workaround this by explicitly waiting for the event to fire.
It isn't simple to modify GetLatestOptions() because we don't want to be reading the entire option set every single time. Instead I think I need to refactor options to instead return functions to get the latest value, instead of the entire set of options.
dibarbet
force-pushed
the
runsettings_integration_test
branch
from
b91d7e4 to
5d3a063
Compare
Cosifne
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #6265 (comment)