Make complexEdit command more robust #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by checking both fsPath and path. Also added logging when there's error.
This was referenced Sep 9, 2023
dibarbet
reviewed
Sep 11, 2023
| throw new Error('Failed to make a complex text edit for completion.'); | ||
| const componentName = '[roslyn.client.completionComplexEdit]'; | ||
| const errorMessage = 'Failed to make a complex text edit for completion.'; | ||
| outputChannel.show(); |
There was a problem hiding this comment.
One thing to consider here - should we put up a toast as well? We have utils for showing an error message. Should only do that though if we want to bring attention to it and don't think it will be popping up all the time.
There was a problem hiding this comment.
good point, we probably can hook up the toast, given this is a failure from user explicitly invoked action. Will add in a follow up PR
dibarbet
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by checking both fsPath and path. Also added logging when there's error.
This is a follow-up on #6315, just in case of unexpected scenarios.
related to:
#6293
#6246