-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflecting changes in vscode to take ranges in SerializableSemanticTokensParams
#6304
Conversation
SerializableSemanticTokensParams
- Changes data to take an array of arrays of number type Related to dotnet/razor#9092
8c3053c
to
6be8367
Compare
- The property type/name was out of sync with razorc counterpart
- Parameter of the ProvideSemanticTokensResponse class constructor.
With magic number -5 Razor Language Server would know that the response is coming from VS Code so it would ignore discarding response due to out of sync error altogether.
Noticing the Local output after running
I will rerun the CI to resolve the failures in the report, in case it happens to be intermittent. |
…es-changes Conflict resolved in CHANGELOG.md
Seems like VS Code is not yet providing support for coloring certain strings and is causing the lines below to show up in red.
Based on this observation, I will be merging the pull request as it is. |
Reflecting changes in vscode-csharp after making
ProvideSemanticTokensResponse
take ranges as input.SerializableSemanticTokensParams
to takeranges
rather thanrange
SemanticTokensResponse
class.Related to dotnet/razor#9092
Local testing:
With feature flag disabled (default behavior for VS code), the ranges array contains one element as expected:
With feature flag turned enabled, the ranges array contains sorted disjoined elements as expected:
Observation
Realized that in vs code we are just using textmate, so the testing involved just assuring the values in ranges are properly mapped over, but the are not really used, in VS code we are just returning dummy empty responses for semantic range requests and just relying on text mate.
Once we complete issue Enable CSharp Semantic tokens in VSCode razor#4323 we'd then be matching behaviors between VS and VS code.