Do not cache calls to dotnet info #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2023
dibarbet
force-pushed
the
do_not_cache_dotnet_info
branch
from
99f9b44 to
5f88d8c
Compare
genlu
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we call dotnet info on startup, we can cache a different value than other callers are expecting (different callers pass in different CLI paths which should output different dotnet info).
The fix is to not cache this because the inputs can change. We do not call this that often that we should need to cache it either.
Also updates the logging to indicate why a potential call to dotnet info failed.
Possibly related to #6179 and #6177 . It doesn't entirely fix them, but it resolves some potential problems.