Read and react to O# option changes only when devkit isnt installed #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkalyanms
changed the title
arkalyanms
changed the title
dibarbet
reviewed
Jul 6, 2023
sharwell
reviewed
Jul 10, 2023
Co-authored-by: Sam Harwell <[email protected]>
|
|
||
| export default function createOptionStream(vscode: vscode): Observable<Options> { | ||
| return Observable.create((observer: Observer<Options>) => { | ||
| const disposable = vscode.workspace.onDidChangeConfiguration((e) => { | ||
| //if the omnisharp or csharp configuration are affected only then read the options | ||
| if ( | ||
| e.affectsConfiguration('dotnet') || | ||
| e.affectsConfiguration('omnisharp') || | ||
| (e.affectsConfiguration('omnisharp') && !vscode.extensions.getExtension(csharpDevkitExtensionId)) || |
There was a problem hiding this comment.
Should this logic instead move to somewhere like
vscode-csharp/src/shared/options.ts
Line 349 in f01115f
It'll probably work either way, but I'm somewhat surprised already that the Omnisharp option isn't being ignored by that.
jasonmalinowski
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #5774