Skip to content

Enable full solution background analysis #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mavasani merged 9 commits into from
Jun 29, 2023
Merged

Enable full solution background analysis #5868

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1269a9b
Enable full solution background analysis
mavasani Jun 27, 2023
f2a826d
Remove the un-supported `Current Document` option
mavasani Jun 27, 2023
fd3bb4f
Avoid using 'solution crawler' terminology in the VSCode option name
mavasani Jun 28, 2023
25650eb
Address feedback and fix test
mavasani Jun 28, 2023
c18825b
Merge remote-tracking branch 'upstream/main' into BackgroundAnalysisO…
mavasani Jun 28, 2023
52260d7
Revert unintentional changes from merge
mavasani Jun 28, 2023
a9da5de
Some more reverts
mavasani Jun 28, 2023
d36fcd0
Address feedback and also fix linting issues
mavasani Jun 28, 2023
6804b88
Move to newer version of Roslyn LSP server
mavasani Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,6 +1285,38 @@
"description": "Show regular expressions in completion list.",
"order": 20
},
"dotnet.backgroundAnalysis.analyzerDiagnosticsScope": {
"type": "string",
"enum": [
"openFiles",
"fullSolution",
"none"
],
"default": "openFiles",
"enumDescriptions": [
"Open documents",
"Entire solution",
"None"
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have loved the descriptions and the enum member names to match :)

Copy link
Contributor Author

@mavasani mavasani Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These match the enum field names and user facing descriptions in VS. I think it would be reasonable to change the enum field names in Roslyn, and once the new values flow into this repo, we can rename the field names here as well. However, these are just internal implementation details, so not sure if it critical to make these changes.

],
"description": "Run background code analysis for:",
"order": 30
},
"dotnet.backgroundAnalysis.compilerDiagnosticsScope": {
"type": "string",
"enum": [
"openFiles",
"fullSolution",
"none"
],
"default": "openFiles",
"enumDescriptions": [
"Open documents",
"Entire solution",
"None"
],
"description": "Show compiler errors and warnings for:",
"order": 30
},
"dotnet.highlighting.highlightRelatedRegexComponents": {
"type": "boolean",
"default": "true",
Expand Down
20 changes: 20 additions & 0 deletions test/unitTests/lspToolHost/configurationMiddleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,26 @@ const testData = [
vsCodeConfiguration: 'codeStyle.formatting.newLine.insertFinalNewline',
declareInPackageJson: false,
},
{
serverOption: 'csharp|background_analysis.dotnet_analyzer_diagnostics_scope',
vsCodeConfiguration: 'dotnet.backgroundAnalysis.analyzerDiagnosticsScope',
declareInPackageJson: true,
},
{
serverOption: 'mystery_language|background_analysis.dotnet_analyzer_diagnostics_scope',
vsCodeConfiguration: null,
declareInPackageJson: false,
},
{
serverOption: 'csharp|background_analysis.dotnet_compiler_diagnostics_scope',
vsCodeConfiguration: 'dotnet.backgroundAnalysis.compilerDiagnosticsScope',
declareInPackageJson: true,
},
{
serverOption: 'mystery_language|background_analysis.dotnet_compiler_diagnostics_scope',
vsCodeConfiguration: null,
declareInPackageJson: false,
},
];

suite('Server option name to vscode configuration name test', () => {
Expand Down