Skip to content

Conversation

@dibarbet
Copy link
Member

The launch.json configurations for debugging O# integration tests were not working well for a couple reasons

  1. It had disable all extensions, meaning the dotnet runtime extension was not present and therefore C# failed to activate.
  2. Source maps weren't being included for the test files.

This isn't where we want to be long term for integration tests, but its a bit better.

@dibarbet dibarbet requested a review from akhera99 June 23, 2023 23:18
@dibarbet dibarbet requested a review from a team as a code owner June 23, 2023 23:18
"--disable-extensions",
// Create a temp profile that has no extensions / user settings.
// This allows us to only have the C# extension + the dotnet runtime installer extension dependency.
"--profile-temp",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This launches vscode with an empty profile with no user settings / extensions. This is better than --disable-extensions as it

  1. Resets settings
  2. Allows us to install dependent extensions if needed.

I would have preferred if we could launch into a specific integration test profile, but that requires the profile to be imported first via a UI wizard. There's no way to launch and import a profile via the vscode cli that I could find.

See microsoft/vscode#159572 (comment)

@dibarbet dibarbet merged commit ea41fa6 into dotnet:main Jun 26, 2023
@dibarbet dibarbet deleted the fix_integration_debug branch June 26, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants