Use the installed dotnet runtime to exec the dll on MacOS instead of the CLI version #5838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac we use an dotnet executable dll instead of an actual executable (currently we only build on windows which doesn't allow us to create a codesigned executable for mac).
However, in this code path we were just launching 'dotnet' on the CLI instead of using the runtime downloaded dotnet. If you don't have .net7 available on the CLI, it'll throw (since the server requires the .net 7 runtime)
This can be reproduced on windows by only having .net 6 installed on the CLI and pointing the server path setting (
dotnet.server.path) to a dll instead of the exe.Resolves #5836