Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licenses for the C# extension #56

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

gregg-miskelly
Copy link
Contributor

This commit addresses issue #42 and other licensing concerns --

  1. Update the readme to reference licensing
  2. Change the package.json to reference the EULA rather than the source license.
  3. Checkin the OpenDebugAD7 license so that it has a home on the web. Needed for its nuget package.

@gregg-miskelly
Copy link
Contributor Author

I think we are having CRLF issues. Let me fix those first.

This commit addresses issue dotnet#42 and other licensing concerns --
1. Update the readme to reference licensing
2. Change the package.json to reference the EULA rather than the source license.
3. Checkin the OpenDebugAD7 license so that it has a home on the web. Needed
for its nuget package.
@gregg-miskelly
Copy link
Contributor Author

Text encoding problems fixed. @DustinCampbell please review.

@DustinCampbell
Copy link
Member

Are there any other notices that we need to include for the various bits third-party software that are included? c.f. https://github.com/OmniSharp/omnisharp-vscode/blob/master/ThirdPartyNotices.txt

@gregg-miskelly
Copy link
Contributor Author

The EULA isn't a replacement for ThirdPartyNotices.txt - one needs both, there is a ThirdPartyNotices.txt which should list all the third party open source that are contained directly in the package, and the EULA needs to indicate that there is third party code. We can certainly link to the ThirdPartyNotices.txt from readme.md, but I don't think it would actually be a requirement.

@DustinCampbell
Copy link
Member

Sounds good. Just wanted to check. I'm no lawyer 😄

gregg-miskelly added a commit that referenced this pull request Mar 3, 2016
Update licenses for the C# extension
@gregg-miskelly gregg-miskelly merged commit 1897842 into dotnet:dev Mar 3, 2016
@gregg-miskelly gregg-miskelly deleted the licenses branch March 3, 2016 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants