Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dnxcore50 from program path template #53

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Conversation

chuckries
Copy link
Contributor

No description provided.

@chuckries
Copy link
Contributor Author

@gregg-miskelly

@chuckries
Copy link
Contributor Author

@caslan

@chuckries
Copy link
Contributor Author

don't merge, Charlie's saying it's not right

@caslan
Copy link
Contributor

caslan commented Mar 1, 2016

It needs to be and not just as they will need to enter names of sub folders.

@caslan
Copy link
Contributor

caslan commented Mar 1, 2016

I meant path-to-program and not my-project-name

@chuckries
Copy link
Contributor Author

FYI using brackets in markdown makes your words disappear so that comment is bogus.

@chuckries
Copy link
Contributor Author

how does the diff look now?

@caslan
Copy link
Contributor

caslan commented Mar 1, 2016

LGTM

@gregg-miskelly
Copy link
Contributor

👍

chuckries added a commit that referenced this pull request Mar 1, 2016
Remove dnxcore50 from program path template
@chuckries chuckries merged commit e912f6b into dotnet:dev Mar 1, 2016
dibarbet added a commit to dibarbet/vscode-csharp that referenced this pull request Jun 8, 2023
Merge LSP feature branch into tools host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants