Code

Low-hanging nullable fruit#5186

Code

Merged

JoeRobich merged 19 commits intodotnet:masterdotnet/vscode-csharp:masterfrom winstliu:low-hanging-nullable-fruitwinstliu/omnisharp-vscode:low-hanging-nullable-fruitCopy head branch name to clipboardApr 25, 2022

+114-176

Commits

Commits on Apr 24, 2022

• Satisfy TSLint

  winstliu

  committed
  a43ea18

• Mark isNetCoreProject as synchronous

  Show description for 8040603
  winstliu

  committed
  8040603

• Remove Range support from createRequest

  Show description for eb8e2a8
  winstliu

  committed
  eb8e2a8

• Nullability fixes for requestQueue

  winstliu

  committed
  b4b0033

• Mark all findNet* functions as nullable

  winstliu

  committed
  ff51b3b

• Nullability fixes for options

  Show description for 6b6a2e4
  winstliu

  committed
  6b6a2e4

• Explicitly check omnisharpPath for undefinedness

  winstliu

  committed
  9b216d2

• Always return bool in DownloadAndInstallOmnisharp

  winstliu

  committed
  e6a3014

• Assert non-null in launcher.ts

  winstliu

  committed
  7a74761

• Guard against possible undefined in LanguageMiddlewareFeature

  winstliu

  committed
  6eea46b

• Change fileToOpen to a nullable type

  winstliu

  committed
  cf029c6

• Remove unused buildPromiseChain

  winstliu

  committed
  592cd72

• Some low-hanging nullability fixes in server

  winstliu

  committed
  6ff620f

• Make localDisposables a nullable type in extension

  winstliu

  committed
  36ddb31

• Mark properties in OmnisharpLaunch as nullable

  winstliu

  committed
  ca1e483

• Update options.path-related unit tests

  winstliu

  committed
  3f4edeb

Commits on Apr 25, 2022

• Test for empty omnisharp.path

  winstliu

  committed
  f665582

• Try not setting defaults for string options

  winstliu

  committed
  43bacd3

• Default string settings to the empty string

  winstliu

  authored
  6576c95