Add support for InlayHint.TextEdits #5177
Merged
+71
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
add-inlayhint-textedit
branch
from
186b486 to
ed35224
Compare
333fred
reviewed
May 20, 2022
|
What are the errors in the example gif? Import errors? If so, is there any way we can have the needed imports added to the text edits? |
In hindsight it was a bad idea to use dotnet/format as an example because the .editorconfig requires the use of |
|
@333fred Opened dotnet/roslyn#61438 to track adding imports when necessary. |
333fred
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot merge until we take a new release of O# that includes OmniSharp/omnisharp-roslyn#2385.
This PR adds support for InlayHint.TextEdits which allows the hint to be double clicked in VS Code. The TextEdits are then applied to the file removing the need for that particular hint.
Screen.Recording.2022-04-21.at.8.42.47.AM.mov