Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install vscode-nls as a dependency #4980

Merged

Conversation

winstliu
Copy link
Contributor

features/json/projectJSONContribution.ts uses the vscode-nls package; however, up until now, it wasn't actually included as a direct dependency:

It's probably a good idea to include it so that its version can be controlled :).

(By the way, what's up with the various zero-width breaking spaces in the package.json? npm keeps trying to convert them to...something else.)

@winstliu winstliu force-pushed the include-vscode-nls-as-a-dependency branch from 992b687 to 7beb68e Compare January 3, 2022 17:26
@winstliu winstliu force-pushed the include-vscode-nls-as-a-dependency branch from 7beb68e to 77f2795 Compare January 3, 2022 17:32
@JoeRobich
Copy link
Member

@50Wliu Thanks for this change.

(By the way, what's up with the various zero-width breaking spaces in the package.json? npm keeps trying to convert them to...something else.)

The goal is to keep certain example urls from being turned into links when viewed in VS Code. It predates me, so perhaps there is a better way now.

@JoeRobich JoeRobich merged commit d20cd03 into dotnet:master Jan 10, 2022
@winstliu winstliu deleted the include-vscode-nls-as-a-dependency branch January 11, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants