Do not start OmniSharp server in Live Share scenarios #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @nohwnd @vzarytovskii |
Codecov Report
@@ Coverage Diff @@
## master #4038 +/- ##
=======================================
Coverage 85.99% 86.00%
=======================================
Files 60 60
Lines 1857 1858 +1
Branches 215 215
=======================================
+ Hits 1597 1598 +1
Misses 200 200
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@JoeRobich can we get this in? it looks to be complete to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3910
Handle Visual Studio Live Share scenarios the same way as the TypeScript extension (https://github.com/microsoft/vscode/blob/master/extensions/typescript-language-features/src/utils/fileSchemes.ts#L20-L28), by disabling our local language server. Language services (limited by what live share supports) are provided by the "server" through live share.