**Review Only** Incorproate coreclr-debug into omnisharp extension #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this should be merged yet but I was hoping to get some feedback. |
|
@gregg-miskelly for discussion |
|
For the minimum supported VSCode version in the package.json, we would like to bump this up to whatever the next release of VSCode is. Do you have any issue with this? |
| function getPlatformLibExtension() : string { | ||
| switch (process.platform) { | ||
| case 'win32': | ||
| return '.lib'; |
There was a problem hiding this comment.
this should be .dll
| _channel.appendLine("Downloading and configuring the .NET Core Debugger..."); | ||
| _channel.show(vscode.ViewColumn.Three); | ||
|
|
||
| vscode.window.setStatusBarMessage("Downloading and configuring the .NET Core Debugger..."); |
1. Adds coreclr-debug.ts to implement coreclr-debug acquisition and hooks it into omnisharp's activation handler 2. Adds the coreclr-debug directory containing the project.json, NuGet.config and dummy.cs required dotnet restore/publish 3. Adds the debugger section to contributes in package.json 4. Adds .vscodeignore to exclude items not needed at runtime from being packaged TODO: 1. Update project.json references 2. Update NuGet.config to not point to http://dbgnuget (switch to nuget.org once pacakges are published publicly) 3. Create some completion file that we can check for correct complete installation 4. Improve reporting status of acquisition to end user
With this commit, the packages pulled in actually work.
1. Add an install log log all output to our vscode OutputChannel 2. Create an install.complete file that is created only on succesfull installation of the tools. Check for the existence of this file to trigger installation
The new packages use copyFiles so dotnet publish will now copy all files we need from the packages. This requires dotnet cli tools at least as new as 1.0.0.001528 (this is the windows version number at least). With contentFiles packages, we no longer need the copy routine and it's helpers.
Pull packages from the public myget and update the dotnet invocations to use verbose output.
| "program": { | ||
| "type": "string", | ||
| "description": "Path to the program (executable file) to launch. On Windows, a '.exe' suffix is appended if not specified already.", | ||
| "default": "${workspaceRoot}/bin/Debug/dnxcore50/<My-Project-Name>" |
There was a problem hiding this comment.
We should merge in the most recent changes that @caslan made to this (removal of 'dnxcore50').
|
Closing in favor of #44. |
dibarbet
added a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Jun 8, 2023
Instantiate the roslyn LSP server with text sync support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it into omnisharp's activation handler
NuGet.config and dummy.cs required dotnet restore/publish
packaged
TODO:
nuget.org once pacakges are published publicly)
installation