Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor to include more C# actions. #3445

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Update Razor to include more C# actions. #3445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@

## 1.21.9 (Not yet released)
* Use the base filename instead of 'ClassName' in ctor snippet (PR:[#3385](https://github.com/OmniSharp/omnisharp-vscode/pull/3385))
* Updated Razor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danroth27 I took the approach of a simple changelog. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!

* Rename support
* Go to definition support
* Go to implementation support
* Find all references support
* CodeLens support
* Several mainline bug fixes

## 1.21.8 (November 11, 2019)
* Update Razor to work for 3.1 SDKs (PR:[#3406](https://github.com/OmniSharp/omnisharp-vscode/pull/3406))
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
],
"defaults": {
"omniSharp": "1.34.8",
"razor": "1.0.0-alpha3-3.1.0-preview3.19563.3"
"razor": "1.0.0-alpha3-5.0.0-alpha.1.19605.17"
},
"main": "./dist/extension",
"scripts": {
Expand Down Expand Up @@ -79,7 +79,7 @@
"http-proxy-agent": "2.1.0",
"https-proxy-agent": "^3.0.1",
"jsonc-parser": "2.0.3",
"microsoft.aspnetcore.razor.vscode": "https://download.visualstudio.microsoft.com/download/pr/55ae404d-0619-4092-82ec-44c2fdac8730/340ebcda4c3e7ecccdc74dadcc13b035/microsoft.aspnetcore.razor.vscode-3.1.0-preview3.19563.3.tgz",
"microsoft.aspnetcore.razor.vscode": "https://download.visualstudio.microsoft.com/download/pr/59f9e3a8-cd84-4b37-927e-256a518e62b9/13987bca9dfe3688ff054c14dda7f5e3/microsoft.aspnetcore.razor.vscode-5.0.0-alpha.1.19605.17.tgz",
"mkdirp": "0.5.1",
"node-filter-async": "1.1.1",
"remove-bom-buffer": "3.0.0",
Expand Down Expand Up @@ -302,8 +302,8 @@
{
"id": "Razor",
"description": "Razor Language Server (Windows / x64)",
"url": "https://download.visualstudio.microsoft.com/download/pr/55ae404d-0619-4092-82ec-44c2fdac8730/43c1ad5dd8a424592bc7e32d1c037786/razorlanguageserver-win-x64-3.1.0-preview3.19563.3.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x64-3.1.0-preview3.19563.3.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/59f9e3a8-cd84-4b37-927e-256a518e62b9/36ef731842d0b93e3f69972bf9b5cf98/razorlanguageserver-win-x64-5.0.0-alpha.1.19605.17.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x64-5.0.0-alpha.1.19605.17.zip",
"installPath": ".razor",
"platforms": [
"win32"
Expand All @@ -315,8 +315,8 @@
{
"id": "Razor",
"description": "Razor Language Server (Windows / x86)",
"url": "https://download.visualstudio.microsoft.com/download/pr/55ae404d-0619-4092-82ec-44c2fdac8730/042166ccbad8038151e1fd8178015fa7/razorlanguageserver-win-x86-3.1.0-preview3.19563.3.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x86-3.1.0-preview3.19563.3.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/59f9e3a8-cd84-4b37-927e-256a518e62b9/e7d9c51b3a91dff4fbd941da04a6533b/razorlanguageserver-win-x86-5.0.0-alpha.1.19605.17.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x86-5.0.0-alpha.1.19605.17.zip",
"installPath": ".razor",
"platforms": [
"win32"
Expand All @@ -328,8 +328,8 @@
{
"id": "Razor",
"description": "Razor Language Server (Linux / x64)",
"url": "https://download.visualstudio.microsoft.com/download/pr/55ae404d-0619-4092-82ec-44c2fdac8730/98bed97d3ae3b39317903f3c8f3e64cd/razorlanguageserver-linux-x64-3.1.0-preview3.19563.3.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-linux-x64-3.1.0-preview3.19563.3.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/59f9e3a8-cd84-4b37-927e-256a518e62b9/2562fe7def9d532cd8a5f7224ba1e9d6/razorlanguageserver-linux-x64-5.0.0-alpha.1.19605.17.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-linux-x64-5.0.0-alpha.1.19605.17.zip",
"installPath": ".razor",
"platforms": [
"linux"
Expand All @@ -344,8 +344,8 @@
{
"id": "Razor",
"description": "Razor Language Server (macOS / x64)",
"url": "https://download.visualstudio.microsoft.com/download/pr/55ae404d-0619-4092-82ec-44c2fdac8730/769a544747adf45a6cea8cf8d7460336/razorlanguageserver-osx-x64-3.1.0-preview3.19563.3.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-osx-x64-3.1.0-preview3.19563.3.zip",
"url": "https://download.visualstudio.microsoft.com/download/pr/59f9e3a8-cd84-4b37-927e-256a518e62b9/d22ddac876bacbedf18c37535aaf9274/razorlanguageserver-osx-x64-5.0.0-alpha.1.19605.17.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-osx-x64-5.0.0-alpha.1.19605.17.zip",
"installPath": ".razor",
"platforms": [
"darwin"
Expand Down
50 changes: 50 additions & 0 deletions test-plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,31 @@ To setup a test project to verify on you can do:
##### C# Signature Help
* Typing `@Html.Raw()` prompts for signature help inside of the `()`.

##### C# Rename
* Renaming "someVariable" in `@{var someVariable = true;} @someVariable` results in both locations being changed.

##### C# Go to definition
* Performing go to definition on "@somevariable" `@{var someVariable = true;} @someVariable` brings you up to where it's declared

##### C# Go to implementation
* Performing go to implementation on "Foo" `@functions {interface Foo {} class Bar: Foo {}}` brings you to where "Bar" is declared

##### C# Find all references
* Performing find all references on "@someVariable" in `@{var someVariable = true;} @(someVariable) @someVariable` results in references to the other instance of someVariable

##### C# CodeLens
* Having the following results in a CodeLens entry above "Foo"
```
@functions {
void Foo()
{
}
}

@Foo()
```
* Clicking on the CodeLens entry results in a find all references window that has an entry for `@Foo()`

##### C# Diagnostics
* Typing `@ThisDoesNotExist` results in an error being created and squiggled in the .cshtml file. NOTE: This error squiggly will be misaligned due to known issues.

Expand Down Expand Up @@ -141,6 +166,31 @@ To setup a test project to verify on you can do:
##### C# Signature Help
* Typing `@SetParameters()` prompts for signature help inside of the `()`.

##### C# Rename
* Renaming "someVariable" in `@{var someVariable = true;} @someVariable` results in both locations being changed.

##### C# Go to definition
* Performing go to definition on "@somevariable" `@{var someVariable = true;} @someVariable` brings you up to where it's declared

##### C# Go to implementation
* Performing go to implementation on "Foo" `@functions {interface Foo {} class Bar: Foo {}}` brings you to where "Bar" is declared

##### C# Find all references
* Performing find all references on "@someVariable" in `@{var someVariable = true;} @(someVariable) @someVariable` results in references to the other instance of someVariable

##### C# CodeLens
* Having the following results in a CodeLens entry above "Foo"
```C#
@functions {
void Foo()
{
}
}

@Foo()
```
* Clicking on the CodeLens entry results in a find all references window that has an entry for `@Foo()`

##### C# Diagnostics
* When no changes have been performed on `Pages/Index.cshtml`, there are 0 errors.
* Typing `@ThisDoesNotExist` results in an error being created and squiggled in the .cshtml file.
Expand Down