Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the omnisharp 1.32.13 updates #2967

Merged
merged 4 commits into from
Apr 5, 2019

Conversation

akshita31
Copy link
Contributor

No description provided.

@akshita31 akshita31 requested a review from rchande April 4, 2019 23:13
@akshita31
Copy link
Contributor Author

PS: We need to change the date in the changelog and update the version in the readme.md and change the link in the readme.md

@@ -47,9 +47,9 @@ export class TelemetryObserver {
case EventType.ProjectConfigurationReceived:
let projectConfig = (<ProjectConfiguration>event).projectConfiguration;
telemetryProps['ProjectGuid'] = projectConfig.ProjectGuid;
Copy link
Contributor

@NTaylorMullen NTaylorMullen Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should also change this to ProjectId. Right @DamianEdwards / @Andrew-MSFT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :-)

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #2967 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2967   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          59       59           
  Lines        1581     1581           
  Branches       89       89           
=======================================
  Hits         1421     1421           
  Misses        149      149           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.87% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/observers/TelemetryObserver.ts 97.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1279c53...22c1090. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #2967 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2967   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files          59       59           
  Lines        1583     1583           
  Branches       89       89           
=======================================
  Hits         1423     1423           
  Misses        149      149           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.89% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/observers/TelemetryObserver.ts 97.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3337aa...d60835d. Read the comment docs.

@akshita31 akshita31 merged commit 4a26dce into dotnet:master Apr 5, 2019
@akshita31 akshita31 deleted the omnisharp_update branch April 5, 2019 20:38
@akshita31
Copy link
Contributor Author

If #2873 is merged by Monday, we can merge it and do the release for 1.18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants