-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the omnisharp 1.32.13 updates #2967
Conversation
PS: We need to change the date in the changelog and update the version in the readme.md and change the link in the readme.md |
src/observers/TelemetryObserver.ts
Outdated
@@ -47,9 +47,9 @@ export class TelemetryObserver { | |||
case EventType.ProjectConfigurationReceived: | |||
let projectConfig = (<ProjectConfiguration>event).projectConfiguration; | |||
telemetryProps['ProjectGuid'] = projectConfig.ProjectGuid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should also change this to ProjectId
. Right @DamianEdwards / @Andrew-MSFT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect :-)
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 59 59
Lines 1581 1581
Branches 89 89
=======================================
Hits 1421 1421
Misses 149 149
Partials 11 11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
=======================================
Coverage 89.89% 89.89%
=======================================
Files 59 59
Lines 1583 1583
Branches 89 89
=======================================
Hits 1423 1423
Misses 149 149
Partials 11 11
Continue to review full report at Codecov.
|
c193d2e
to
d60835d
Compare
If #2873 is merged by Monday, we can merge it and do the release for 1.18.1. |
No description provided.