Use the fsPath instead of path in the virtual document tracker #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchande
approved these changes
Aug 17, 2018
NTaylorMullen
suggested changes
Aug 17, 2018
| @@ -63,7 +63,7 @@ function shouldIgnoreDocument(document: TextDocument, server: OmniSharpServer): | |||
| } | |||
|
|
|||
| async function openVirtualDocument(document: TextDocument, server: OmniSharpServer, eventStream: EventStream) { | |||
| let req = { FileName: document.uri.path, changeType: FileChangeType.Create }; | |||
| let req = { FileName: document.uri.fsPath, changeType: FileChangeType.Create }; | |||
There was a problem hiding this comment.
You need to fallback to .path. Aka,
let path = document.uri.fsPath;
if (!path) {
path = document.uri.path;
}Same below.
Codecov Report
@@ Coverage Diff @@
## master #2465 +/- ##
==========================================
+ Coverage 63.59% 64.13% +0.53%
==========================================
Files 90 90
Lines 4104 4110 +6
Branches 587 589 +2
==========================================
+ Hits 2610 2636 +26
+ Misses 1328 1296 -32
- Partials 166 178 +12
Continue to review full report at Codecov.
|
NTaylorMullen
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual document tracker was sending a file change request with "path" instead of fsPath. The path was not a valid file system path and was causing omnisharp to crash when a deleted file was being opened in the git side-bar( OmniSharp/omnisharp-roslyn#1252 (comment)).