Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for C# 6 keywords #111

Closed
wants to merge 1 commit into from
Closed

Conversation

jamesqo
Copy link
Contributor

@jamesqo jamesqo commented Mar 19, 2016

C# 6 introduces 2 new keywords, nameof and when. I've updated the csharp.json file to include these keywords among the other ones that are currently recognized, such as typeof and sizeof.

@DustinCampbell
Copy link
Member

Hi! Sorry for not replying sooner.

First, thanks very much for taking the time to submit a PR. Because this is a Microsoft-owned project, we're working on setting up the machinery to handle CLAs. Once that happens, would you be willing to sign one (if you haven't already)?

@jamesqo
Copy link
Contributor Author

jamesqo commented Mar 23, 2016

@DustinCampbell Sure! In fact I believe I've already signed the CLA (see here), so that shouldn't be a problem.

@DustinCampbell
Copy link
Member

Great! Hopefully the CLA automation will simply recognize you as having already signed.

@dnfclas
Copy link

dnfclas commented Apr 15, 2016

Hi @jamesqo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@DustinCampbell
Copy link
Member

@jamesqo, we're on lockdown in master, so I'm going to rebase against dev. Thanks again for your contribution!

@DustinCampbell
Copy link
Member

OK, I've rebased and submitted #192. Thanks for your contribution @jamesqo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants