Enable tslint #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| gulp.task('tslint', function () { | ||
| gulp.src(allTypeScript) | ||
| .pipe(filter(tslintFilter)) |
There was a problem hiding this comment.
@egamma To my knowledge you don't need the filter but you can invoke src like so gulp.src(['src/**/*.ts', '!**/*.d.ts', '!**/typings**',etc]
There was a problem hiding this comment.
Yep, this works and it is simpler, updated the PR.
| '!**/*.d.ts', | ||
| '!**/typings/**' | ||
| ]; | ||
|
|
|
tss... next attempt |
|
LGTM |
DustinCampbell
added a commit
that referenced
this pull request
Feb 18, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
added a commit
that referenced
this pull request
Feb 18, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
added a commit
that referenced
this pull request
Feb 26, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
added a commit
that referenced
this pull request
Feb 26, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
added a commit
that referenced
this pull request
Mar 1, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
referenced
this pull request
in DustinCampbell/vscode-csharp
Mar 2, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, dotnet#2 and dotnet#3 would be ignored even if the value of #1 was invalid. Likewise, if dotnet#2 was set, dotnet#3 would be ignored even if the value of dotnet#2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
referenced
this pull request
in DustinCampbell/vscode-csharp
Mar 4, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, dotnet#2 and dotnet#3 would be ignored even if the value of #1 was invalid. Likewise, if dotnet#2 was set, dotnet#3 would be ignored even if the value of dotnet#2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
DustinCampbell
added a commit
that referenced
this pull request
Mar 4, 2016
The extension looks in three locations for OmniSharp: 1. Whatever the user specified in the "csharp.omnisharp" setting. 2. The value of the "OMNISHARP" environment variable. 3. The expected location where the bundled OmniSharp is copied. If #1 was set, #2 and #3 would be ignored even if the value of #1 was invalid. Likewise, if #2 was set, #3 would be ignored even if the value of #2 was invalid. This change adds fallback logic to try the next option if an invalid value is encountered. In addition, it is more robust depending on whether a file or directory name is specified. If the value is a directory, it will try 'run' (run.cmd on Windows) or 'omnisharp' (omnisharp.exe on Windows) as possible launch file names.
Closed
Samirat
added a commit
to github/omnisharp-vscode
that referenced
this pull request
May 21, 2020
Add DiscoverTests request, NoBuild option for test requests
wittelw
pushed a commit
to wittelw/omnisharp-vscode
that referenced
this pull request
Aug 25, 2021
Armv7l aarch64
dibarbet
pushed a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/vscode#2030.