Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Debugger should better handle Console.Read APIs with internalConsole #5704

Closed
Tracked by #579
gregg-miskelly opened this issue Jun 6, 2023 · 0 comments
Closed
Tracked by #579

Feature: Debugger should better handle Console.Read APIs with internalConsole #5704

gregg-miskelly opened this issue Jun 6, 2023 · 0 comments
Assignees
@gregg-miskelly
Labels
Debugger Feature Request Resolved-Fixed

Comments

@gregg-miskelly
Copy link
Contributor

Currently the debugger defaults to internalConsole, which produces the best experience when NOT using Console.Read* (example: Console.ReadLine), but breaks reading from the console.

There are two possible ways the debugger could improve this --

  1. Warn. The debugger could set internal breakpoints on all the Console.Read APIs so that we can stop and warn the user what happened.
  2. Use the evaluation window. Potentially we could treat any attempt to evaluate while the program is running as input to the program.

This code would need to disable itself whenever standard input is redirected.
@gregg-miskelly gregg-miskelly mentioned this issue Oct 11, 2023
Closed
@gregg-miskelly gregg-miskelly self-assigned this Oct 16, 2023
This was referenced Oct 18, 2023
Open
Merged
gregg-miskelly added a commit that referenced this issue Oct 19, 2023
@gregg-miskelly
Debugger: Support Console.ReadLine with 'internalConsole' (#6569)
0b7f6c8 
This PR pulls in a new version of the debugger that supports `Console.ReadLine` and `Console.Read` when using `"console":"internalConsole"` (the default value). This also updates documentation.

This addresses #5704

Two other minor changes I noticed while I was here:
* Updated the changelog to correctly indicate when the 'long string' fix went it
* Updated links in the debugger md files that were still pointing at OmniSharp
@webreidi webreidi mentioned this issue Oct 25, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregg-miskelly gregg-miskelly

Labels
Debugger Feature Request Resolved-Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dibarbet @gregg-miskelly @arunchndr