Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method return type syntax highlighting issues #33

Closed
aeschli opened this issue Feb 9, 2016 · 5 comments · Fixed by #689
Closed

Method return type syntax highlighting issues #33

aeschli opened this issue Feb 9, 2016 · 5 comments · Fixed by #689

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 9, 2016

From @TheColorRed on February 6, 2016 3:18

Theme: Colorful Default Themes (Dark)

There is still a small issue when syntax highlighting generators, as you can see from this screenshot:

screenshot from 2016-02-05 21-15-55

When using a generator, everything becomes white. Also the class definition in the foreach is also white.

Copied from original issue: microsoft/vscode#2756

@aeschli
Copy link
Contributor Author

aeschli commented Feb 9, 2016

@TheColorRed Thanks for reporting this. Can you paste the code snippet as well, to speed up the instigations?

@aeschli
Copy link
Contributor Author

aeschli commented Feb 9, 2016

From @TheColorRed on February 9, 2016 16:48

Here is the code:

public GameObject[] GetItems(string name){
    List<GameObject> items = new List<GameObject>();
    foreach(InventoryItem i in inventoryItems){
        if(i.itemName == name){
            items.Add(i.gameObject);
        }
    }
    return items.ToArray();
}

public GameObject[] GetItems<T>(){
    List<GameObject> items = new List<GameObject>();
    foreach(var i in inventoryItems){
        if(i.GetType() == typeof(T)){
            items.Add(i.gameObject);
        }
    }
    return items.ToArray();
}

Note: the type hinting in the foreach also isn't highlighted.

@ivanz
Copy link
Contributor

ivanz commented Aug 18, 2016

image

@ivanz
Copy link
Contributor

ivanz commented Aug 18, 2016

@DustinCampbell Can you please label this with "Syntax highlighting", so that when I come back to looking at this I can potentially look at fixing it. Or maybe @seraku24 will beat me to it ;)

@ivanz
Copy link
Contributor

ivanz commented Aug 18, 2016

Also change the title to "Method return type syntax highlighting issues" or something 👍

@DustinCampbell DustinCampbell changed the title Generator Syntax Highlighting Broken Method return type syntax highlighting issues Aug 18, 2016
@DustinCampbell DustinCampbell added this to the 1.4 milestone Aug 18, 2016
dibarbet added a commit to dibarbet/vscode-csharp that referenced this issue Jun 8, 2023
Create basic initial LSP server project and extension code to connect to it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants