Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debugger proxy code #1929

Closed
chuckries opened this issue Dec 19, 2017 · 7 comments
Closed

Remove debugger proxy code #1929

chuckries opened this issue Dec 19, 2017 · 7 comments
Assignees
@WardenGnaw
Labels
Debugger Debugger-Install Resolved-Fixed

Comments

@chuckries
Copy link
Contributor

Starting in 1.9, VS Code allows an extension command to be registered that will dynamically produce the path and args to the debugger executable. Summary.

With this, we should be able to remove our proxy code and do the equivalent in a command. This has some benefits as we will be running in the VS Code process, have access to the VS Code APIs, and we will not need to rewrite the manifest to move from the proxy to vsdbg-ui.
@WardenGnaw WardenGnaw self-assigned this Dec 19, 2017
@WardenGnaw WardenGnaw mentioned this issue Dec 20, 2017
Closed
WardenGnaw added a commit to WardenGnaw/omnisharp-vscode that referenced this issue Dec 21, 2017
@WardenGnaw
Removing proxy.ts and install.ts
dd251cc 
Addressing Issue dotnet#1929
With adapterExecutableCommand there is no need to rewrite the manifest.
Registering a command to return the correct executable.
@WardenGnaw WardenGnaw mentioned this issue Dec 21, 2017
Merged
WardenGnaw added a commit that referenced this issue Jan 4, 2018
@WardenGnaw
Fixing Issue #1929: Removing proxy.ts and install.ts (#1932)
4dd381f 
* Removing proxy.ts and install.ts

Addressing Issue #1929
With adapterExecutableCommand there is no need to rewrite the manifest.
Registering a command to return the correct executable.
@DustinCampbell
Copy link
Member

@WardenGnaw : Should this issue be resolved as fixed and closed now?

@WardenGnaw
Copy link
Contributor

Yep! Forgot to close this issue.

@DustinCampbell
Copy link
Member

Is there a changelog update for this issue? Or, does it not affect the experience meaningfully?

@chuckries
Copy link
Contributor Author

This should be invisible to the user.

@DustinCampbell
Copy link
Member

That's what I thought. I just wanted to check.

@WardenGnaw
Copy link
Contributor

I believe the only issue would be if someone decides to F5 before the extension is activated and registers the command, VsCode will complain that the command is not found.

@DustinCampbell
Copy link
Member

sure. That seems low-impact enough to leave out of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardenGnaw WardenGnaw

Labels
Debugger Debugger-Install Resolved-Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DustinCampbell @WardenGnaw @chuckries