Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add out of support within days config #68

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Add out of support within days config #68

merged 1 commit into from
Nov 8, 2021

Conversation

IEvangelist
Copy link
Member

Added a config value that will allow us to specify the number of additional days to consider flagging versions that will be out of support. For example:

{
  "outOfSupportWithinDays": 90,
  "ignore": [
    "**/pinned-versions/**",
    "**/*.fsproj"
  ]
}

This will flag all out of support versions, but also versions that will be out of support 90 days from now.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @IEvangelist

You can :shipit: when ready.

@IEvangelist IEvangelist merged commit bb17f16 into main Nov 8, 2021
@Gakk
Copy link
Contributor

Gakk commented Nov 11, 2022

@IEvangelist This flag is not documented in neither README.md nor action.yml. Is it still working, or has it been removed later?

EDIT: I now discovered that this value is in the json-file. I would really love if this could be a normal optional input to the action, instead of creating a new file.

@IEvangelist
Copy link
Member Author

Good catch, @Gakk. Thanks for calling attention to this. Are you using this GitHub Action?

@Gakk
Copy link
Contributor

Gakk commented Nov 11, 2022

I am product manager for a double digit number of products, and have for a long time used Dependabot to help manage both package upgrades and newer versions of actions.

A short while ago I looked at a .NET repository and noticed it used your action to check target version for projects.

When using a new product/package I usually read through release notes, issues and pull request to get a feeling on how the product is evolving and being maintained. That's when I noticed this feature for number of days 😇

@IEvangelist IEvangelist deleted the addDays branch May 20, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants