Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly containerize the .NET GitHub action #19

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Properly containerize the .NET GitHub action #19

merged 2 commits into from
Feb 23, 2021

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Feb 23, 2021 •
edited
Loading

Based on observations from a previous PR, #17 (comment).

  • Deleted the /dist directory
  • Re-define Dockerfile to build the image itself - based on this guide
  • Clean up .gitignore file
  • Add .dockerignore file

Fixes #18

@IEvangelist IEvangelist self-assigned this Feb 23, 2021
@IEvangelist IEvangelist added the enhancement New feature or request label Feb 23, 2021
BillWagner
BillWagner approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @IEvangelist

You can :shipit: when ready.

@IEvangelist IEvangelist merged commit 1ee92e1 into main Feb 23, 2021
@IEvangelist IEvangelist deleted the properly-containerize branch February 23, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@IEvangelist IEvangelist

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properly containerize action
2 participants
@IEvangelist @BillWagner