Skip to content

Conversation

@Sapana-Khemkar
Copy link

This fixes issue #277
Support for ppc64le processor architecture has been added in VSTest repo here which is part of release 17.4.0.
Hence on ppc64le, we have to use Microsoft.NET.Test.Sdk version 17.4.0 in templates.
Note:
I have changed version in 7.0 template only as ppc64le is supported from .NET7 only. Not sure if we want to upgrade version for all versions.

@omajid
Copy link
Member

omajid commented Jan 17, 2023

I would upgrade the templates for 8.0 as well, but not the earlier ones.

@Sapana-Khemkar
Copy link
Author

I would upgrade the templates for 8.0 as well, but not the earlier ones.

sure will do that

@crummel
Copy link
Contributor

crummel commented Feb 7, 2023

@Sapana-Khemkar who do we need to review this? @nohwnd ?

@Evangelink
Copy link
Member

@Sapana-Khemkar who do we need to review this? @nohwnd ?

I am on it :)

I would upgrade the templates for 8.0 as well, but not the earlier ones.

We usually update all because the insertion is blocked on dotnet/installer side. Truethly speaking, I think it would be better to update only new templates as it makes it hard to look at this repo and understand why versions don't match local but that's discussion for another PR.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update all templates and use v17.4.1 instead?

@MarcoRossignoli
Copy link
Member

we will close this one because we're changing the templating strategy. We will open a new one asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants