Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Conditionaly typo #8087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp SimonCropp requested a review from a team as a code owner June 11, 2024 06:14
@joeloff joeloff added the area: api Related to public API changes/bugs label Jun 11, 2024
@MiYanni MiYanni added the breaking-change Things that should be mentioned as breaking change in release notes. label Jun 11, 2024
@@ -34,7 +34,7 @@ public enum PrecedenceDefinition
/// <summary>
/// Parameter might become disabled - value would not be needed nor used in such case.
/// </summary>
ConditionalyDisabled,
ConditionallyDisabled,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could avoid the breaking change by adding the corrected enum value and hiding the existing one

[EditorBrowsable(EditorBrowsableState.Never)]
ConditionalyDisabled

and

ConditionallyDisabled = ConditionalyDisabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or mark ConditionalyDisabled as obsolete

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Related to public API changes/bugs breaking-change Things that should be mentioned as breaking change in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants