Merge pull request #8232 from dotnet/backport/pr-8231-to-release/8.0.1xx

[release/8.0.1xx] Avoid allocations from calls to CultureInfo.GetCultures
dotnet · Aug 7, 2024 · 4a85a62 · 4a85a62
2 parents 11cd79c + 663a610
commit 4a85a62
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/DirectoryBasedTemplate.cs b/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/DirectoryBasedTemplate.cs
@@ -142,9 +142,14 @@ internal Task ValidateAsync(ValidationScope scope, CancellationToken cancellatio
         {
             string filename = locFile.Name;
             string localeStr = filename.Substring(LocalizationFilePrefix.Length, filename.Length - LocalizationFilePrefix.Length - LocalizationFileExtension.Length);
+            CultureInfo? locale = null;
 
-            CultureInfo? locale = CultureInfo.GetCultures(CultureTypes.AllCultures).FirstOrDefault(c => c.Name.Equals(localeStr, StringComparison.OrdinalIgnoreCase));
-            if (locale == null)
+            try
+            {
+                // PERF: Avoid calling CultureInfo.GetCultures and searching the results as it heavily allocates on each invocation.
+                locale = CultureInfo.GetCultureInfo(localeStr);
+            }
+            catch (CultureNotFoundException)
             {
                 Logger.LogWarning(LocalizableStrings.LocalizationModelDeserializer_Error_UnknownLocale, localeStr);
             }