Use HTTP2 full duplex for committing session #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
force-pushed
the
full-duplex
branch
2 times, most recently
from
3b2eb82 to
57c5133
Compare
twsouthwick
force-pushed
the
full-duplex
branch
from
1e90db1 to
f5a5b61
Compare
twsouthwick
force-pushed
the
full-duplex
branch
from
f5a5b61 to
191ad8b
Compare
mjrousos
approved these changes
Jan 7, 2025
...Core.SystemWebAdapters.CoreServices/SessionState/RemoteSession/RemoteAppSessionDispatcher.cs
Show resolved
Hide resolved
...SystemWebAdapters.CoreServices/SessionState/RemoteSession/RemoteAppSessionStateExtensions.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote session sharing current creates two connections when in non-readonly mode:
This PR adds a POST verb to the endpoint that expects full-duplex streaming to be available and allows
for receiving the session state first and then sending the result back once committed.
Since this requires HTTP2 and SSL, there is a flag to go back to the original implementation as well.
For readonly mode, the original client implementation is used as it calls the GET endpoint and doesn't
need to send any results back.