Skip to content

Copy the keys from framework session state #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Copy the keys from framework session state #559

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9a56e
Copy the keys from framework session state
twsouthwick Dec 4, 2024
675fc2b
remove usings
twsouthwick Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...emWebAdapters.FrameworkServices/SessionState/Serialization/HttpSessionStateBaseWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Collections.Generic;
using System.Collections.Specialized;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using System.Web;
using System.Web.SessionState;

namespace Microsoft.AspNetCore.SystemWebAdapters.SessionState;

Expand Down Expand Up @@ -54,7 +56,17 @@ public bool IsAbandoned
}
}

public IEnumerable<string> Keys => State.Keys.Cast<string>();
public IEnumerable<string> Keys
{
get
{
// If the underlying storage mechanism is SessionStateItemCollection then there can be issues around the enumerator causing side effects.
// There are precautions in the implementation to prevent this, but we have seen an exception around this in practice (see dotnet/systemweb-adapters#556).
// However, there is no simple way to check if this is the case, so we'll preemptively create a copy.
// See https://referencesource.microsoft.com/#System.Web/State/SessionStateItemCollection.cs,435 for the warnings in the implementation.
return [.. State.Keys.Cast<string>()];
}
}

public void Clear() => State.Clear();

Expand Down