Add back HttpRequest.LogonUserIdentity #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this had been added typed as IIdentity which was incorrect. This adds it back as WindowsIdentity and exposes it via a feature so it can be easily customized if needed. By default, it will use the current user and check if it has a WindowsIdentity and return that.
|
@joperezr can I get a review on this? |
joperezr
reviewed
Aug 5, 2024
src/Microsoft.AspNetCore.SystemWebAdapters/Microsoft.AspNetCore.SystemWebAdapters.csproj
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Aug 5, 2024
|
Left a comment but looks good otherwise. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this had been added typed as IIdentity which was incorrect. This adds it back as WindowsIdentity and exposes it via a feature so it can be easily customized if needed. By default, it will use the current user and check if it has a WindowsIdentity and return that.
Fixes #525