Skip to content

Remove obsolete members for v2.0 #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Remove obsolete members for v2.0 #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 1 addition & 36 deletions src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/SessionAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,44 +9,9 @@ namespace Microsoft.AspNetCore.SystemWebAdapters;
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method)]
public sealed class SessionAttribute : Attribute
{
[Obsolete("Prefer SessionBehavior instead.")]
public SessionBehavior Behavior
{
get
{
if (SessionBehavior is SessionStateBehavior.Disabled)
{
return SystemWebAdapters.SessionBehavior.None;
}

return IsPreLoad ? SystemWebAdapters.SessionBehavior.Preload : SystemWebAdapters.SessionBehavior.OnDemand;
}
set
{
SessionBehavior = value switch
{
SystemWebAdapters.SessionBehavior.None => SessionStateBehavior.Disabled,
SystemWebAdapters.SessionBehavior.Preload => SessionStateBehavior.Required,
SystemWebAdapters.SessionBehavior.OnDemand => SessionStateBehavior.Required,
_ => throw new ArgumentOutOfRangeException(nameof(value)),
};
}
}

public SessionStateBehavior SessionBehavior { get; set; } = SessionStateBehavior.Required;

public bool IsPreLoad { get; set; } = true;

public bool IsReadOnly
{
get => SessionBehavior is SessionStateBehavior.ReadOnly;
[Obsolete("Prefer SessionBehavior property")]
set
{
if (value)
{
SessionBehavior = SessionStateBehavior.ReadOnly;
}
}
}
public bool IsReadOnly => SessionBehavior is SessionStateBehavior.ReadOnly;
}
29 changes: 0 additions & 29 deletions src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/SessionBehavior.cs
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions ...stemWebAdapterBuilderSessionExtensions.cs → ...State/Wrapped/WrappedSessionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.ComponentModel;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.SystemWebAdapters;
using Microsoft.AspNetCore.SystemWebAdapters.SessionState.Serialization;
Expand All @@ -11,13 +10,8 @@

namespace Microsoft.Extensions.DependencyInjection;

public static class ISystemWebAdapterBuilderSessionExtensions
public static class WrappedSessionExtensions
{
[Obsolete("Prefer AddWrappedAspNetCoreSession instead")]
[EditorBrowsable(EditorBrowsableState.Never)]
public static ISystemWebAdapterBuilder WrapAspNetCoreSession(this ISystemWebAdapterBuilder builder, Action<SessionOptions>? options = null)
=> builder.AddWrappedAspNetCoreSession(options);

public static ISystemWebAdapterBuilder AddWrappedAspNetCoreSession(this ISystemWebAdapterBuilder builder, Action<SessionOptions>? options = null)
{
ArgumentNullException.ThrowIfNull(builder);
Expand Down