Skip to content

Add support for HttpApplication.PreSendRequestContent #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add support for HttpApplication.PreSendRequestContent #515

merged 2 commits into from
Jul 24, 2024

Conversation

@twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Jul 12, 2024 •
edited
Loading

In order to support this event, we need to hook into the point at which content is flushed to the client. To achieve this, this change adds the following:

  • A new implementation of IHttpResponseBodyFeature that gets added early when modules are registered that will intercept calls to FlushAsync
  • Moves the PreSendRequestHeaders to the same interception point
  • Reworks tests to run all the module tests for both buffered and non-buffered streams

@twsouthwick twsouthwick mentioned this pull request Jul 12, 2024
Closed
TaoziZ03
TaoziZ03 approved these changes Jul 13, 2024
View reviewed changes
Copy link

@TaoziZ03 TaoziZ03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@twsouthwick twsouthwick added this to the 2.0 milestone Jul 17, 2024
Base automatically changed from presend-headers to main July 18, 2024 21:47
@twsouthwick twsouthwick force-pushed the presend-content branch 3 times, most recently from 70caf23 to 01c0ecb Compare July 19, 2024 00:36
@twsouthwick twsouthwick marked this pull request as ready for review July 19, 2024 00:36
@twsouthwick twsouthwick requested a review from joperezr July 19, 2024 00:36
@twsouthwick
Copy link
Member Author

twsouthwick commented Jul 19, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 19, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@twsouthwick twsouthwick force-pushed the presend-content branch 2 times, most recently from e83be81 to 1dda4aa Compare July 19, 2024 17:44
@twsouthwick
Copy link
Member Author

twsouthwick commented Jul 23, 2024

@joperezr can I get a review of this pr?

@twsouthwick twsouthwick enabled auto-merge (squash) July 23, 2024 23:06
@twsouthwick twsouthwick merged commit 8f98df5 into main Jul 24, 2024
@twsouthwick twsouthwick deleted the presend-content branch July 24, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joperezr joperezr joperezr approved these changes

+1 more reviewer

@TaoziZ03 TaoziZ03 TaoziZ03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@twsouthwick @joperezr @TaoziZ03