Skip to content

Conversation

@twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Jul 12, 2024

Fixes #514

@twsouthwick
Copy link
Member Author

This is stacked against #509 since it requires the ability to disable buffering to test it.

@twsouthwick twsouthwick force-pushed the presend-headers branch 2 times, most recently from 784c2db to 836fcc7 Compare July 12, 2024 18:34
Copy link

@TaoziZ03 TaoziZ03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@twsouthwick twsouthwick added this to the 2.0 milestone Jul 17, 2024
Base automatically changed from disable-buffering to main July 18, 2024 18:48
@twsouthwick twsouthwick marked this pull request as ready for review July 18, 2024 18:51
@twsouthwick twsouthwick requested a review from joperezr July 18, 2024 18:51
<PackageReference Include="AutoFixture" Version="4.15.0" />
<PackageReference Include="Moq" Version="4.16.1" />
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.13" />
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to your PR, but we should think about setting up dependabot or some other way to automatically bump these dependencies in the future.

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Taylor!

@twsouthwick twsouthwick merged commit 6cc8452 into main Jul 18, 2024
@twsouthwick twsouthwick deleted the presend-headers branch July 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PreSendRequestHeaders and PreSendRequestContent should be fired when content is being sent

4 participants