Skip to content

Update caching to v8.0.0 on .NET 8.0 build #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Update caching to v8.0.0 on .NET 8.0 build #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/Microsoft.AspNetCore.SystemWebAdapters/Microsoft.AspNetCore.SystemWebAdapters.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0;netstandard2.0;net45;net472</TargetFrameworks>
Expand Down Expand Up @@ -33,10 +33,22 @@
<Compile Include="HtmlString.cs" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'net8.0' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">

<FrameworkReference Include="Microsoft.AspNetCore.App" />

<PackageReference Include="System.Runtime.Caching" Version="6.0.0" />

<Using Include="Microsoft.AspNetCore.Http.HttpContext" Alias="HttpContextCore" />
Copy link
Member

@mjrousos mjrousos Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of duplication here. Could we just have a property "SystemRuntimeCachingVersion" that is set differently depending on whether we're targeting net6.0 or net8.0 and not duplicate this whole ItemGroup?

<Using Include="Microsoft.AspNetCore.Http.HttpResponse" Alias="HttpResponseCore" />
<Using Include="Microsoft.AspNetCore.Http.HttpRequest" Alias="HttpRequestCore" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
<FrameworkReference Include="Microsoft.AspNetCore.App" />

<PackageReference Include="System.Runtime.Caching" Version="8.0.0" />

<Using Include="Microsoft.AspNetCore.Http.HttpContext" Alias="HttpContextCore" />
<Using Include="Microsoft.AspNetCore.Http.HttpResponse" Alias="HttpResponseCore" />
<Using Include="Microsoft.AspNetCore.Http.HttpRequest" Alias="HttpRequestCore" />
Expand Down