Skip to content

Conversation

@jherven
Copy link
Contributor

@jherven jherven commented Nov 27, 2023

Don't force default content-type if no content
If response has no content, don't automatically add content-type header

PR Description

  • If response has content nothing changes
  • If response has no content don't automatically add any content-type header

Addresses #449

Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests that are probably failing here

@jherven jherven force-pushed the no-default-content-type-for-no-content branch from 672cb95 to 27be096 Compare November 28, 2023 19:53
@jherven
Copy link
Contributor Author

jherven commented Nov 28, 2023

@dotnet-policy-service agree

…aultResponseHeadersMiddleware.cs

Co-authored-by: Taylor Southwick <[email protected]>
@jherven
Copy link
Contributor Author

jherven commented Nov 28, 2023

There are some tests that are probably failing here

How could I miss those. Updated

@twsouthwick twsouthwick merged commit 1a0c991 into dotnet:main Nov 28, 2023
@twsouthwick
Copy link
Member

Thanks @jherven for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants