Separate HttpApplication feature insertion from invocation #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the features for HttpApplication to be insterted in the HttpContext at the beginning of the request, but will only be invoked in the `.UseSystemWebAdapters()` middleware call. This enables a request to potentially modify behavior of the features if needed before invoking the middleware. A nice side effect of this is that an HttpApplication will only be created if it is actually used within a request, otherwise, it will never be retrieved (which is one of the more expensive parts of the emulated IIS pipeline as we have to assign an HttpApplication to a request).
Tratcher
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the features for HttpApplication to be insterted in the HttpContext at the beginning of the request, but will only be invoked in the
.UseSystemWebAdapters()middleware call. This enables a request to potentially modify behavior of the features if needed before invoking the middleware.A nice side effect of this is that an HttpApplication instance will only be retrieved from the pool if it is actually used within a request, otherwise, it will never be retrieved. This is one of the more expensive parts of the emulated IIS pipeline as we have to assign an HttpApplication to a request, so it can potentially prevent a request from needing to perform this.