Use TimeProvider to set HttpContext.Timestamp #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use this, we need to move the timestamp to a feature so we can set this in the middleware where we have TimeProvider. As a benefit of this, we won't prematurely create a `System.Web.HttpContext` to initialize the time; instead, the feature will be created, but that's it. Another change this requires is to add a .NET 8 build for the CoreServices library, which raises a few new warnings about some API changes that are addressed in this PR as well.
Tratcher
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use this, we need to move the timestamp to a feature so we can set this in the middleware where we have TimeProvider. As a benefit of this, we won't prematurely create a
System.Web.HttpContextto initialize the time; instead, the feature will be created, but that's it.Another change this requires is to add a .NET 8 build for the CoreServices library, which raises a few new warnings about some API changes that are addressed in this PR as well.