Move HttpApplication middleware into UseSystemWebAdapters #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was initially moved into the startup filter to be added early on in the request pipeline because it was thought it was needed there for output caching. However, that does not seem to be the case (test has been added for that). So, now it can be moved into the standard `UseSystemWebAdapters()` so that it will be only added on requests that needed it (i.e. if the pipeline has been branched and `UseSystemWebAdapters()` is not added).
Tratcher
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially moved into the startup filter to be added early on in the request pipeline because it was thought it was needed there for output caching. However, that does not seem to be the case (test has been added for that). So, now it can be moved into the standard
UseSystemWebAdapters()so that it will be only added on requests that needed it (i.e. if the pipeline has been branched andUseSystemWebAdapters()is not added).Fixes #405