Adding more browser capabilities #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
reviewed
Sep 20, 2023
|
|
||
| public Version? W3CDomVersion => new Version(Capability["w3cdomversion"]); | ||
|
|
||
| public virtual bool SupportsCallback => GetBoolean("supportsCallback"); |
There was a problem hiding this comment.
let's remove the virtual here
birojnayak
force-pushed
the
main
branch
2 times, most recently
from
d3974a6 to
6176a2f
Compare
twsouthwick
requested changes
Sep 21, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/Configuration/HttpCapabilitiesBase.cs
Outdated
Show resolved
Hide resolved
twsouthwick
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Adding more browser capabilities
PR Description
Detail 1
Detail 2
Addresses #bugnumber (in this specific format)