Use an options type for hosting and runtime environment #389
Conversation
This refactors the runtime environment to be configured via a user-available options type. By default, if running on IIS, this will be populated, but can easily be configured if needed. This also adds HostingEnvironment properties that may be expected via the same options. As part of this, a hosted service is added that will set the options as a static instance so it will be available for the lifetime of the service (since the APIs on HttpRuntime and HostingEnvironment were static). This hosted service will take care of clearing this value once the host is stopped.
|
@Tratcher this enables the HostingEnvironment APIs on the adapter side. Once dotnet/aspnetcore#43632 is available, we can hook it up as a separate PR. This enables customizing the values surfaced through the APIs, though, so can be useable without the full IIS hookup. |
|
|
||
| Task IHostedService.StartAsync(CancellationToken cancellationToken) | ||
| { | ||
| HostingEnvironmentAccessor.Current = _accessor; |
There was a problem hiding this comment.
Why not set it directly in the HostingEnvironmentService or HostingEnvironmentAccessor constructors? And null it out in Dispose? You just need a live service container, not a running host, right?
There was a problem hiding this comment.
The HostingEnvironmentAccessor would need to be activated somehow to set it in its constructor. The goal here was to only have it set while running so it could be removed when not in use. Mostly for unit tests that I set to be run in serial and require that clean up to ensure tests aren't stomping on each other.
I switched it to use an IStartupFilter so it will be auto-activated instead of a hosted service (is there a difference in overhead here?).
This refactors the runtime environment to be configured via a user-available options type. By default, if running on IIS, this will be populated, but can easily be configured if needed.
This also adds HostingEnvironment properties that may be expected via the same options.
As part of this, a hosted service is added that will set the options as a static instance so it will be available for the lifetime of the service (since the APIs on HttpRuntime and HostingEnvironment were static). This hosted service will take care of clearing this value once the host is stopped.
Fixes #368
Blocked by dotnet/aspnetcore#43632 for full support