Handle null session values #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does the following to handle null values (including nullable structs): 1. Allow null values to be passed into ISessionKeySerializer.TrySerialize 2. Check if null (or if Nullable<>) and serialize it 3. Remove special casing of null values in the SessionState default serializer (BinarySessionSerializer), which also requires a bump in version 4. The BinarySessionSerializer is updated to understand reading v1 or v2 values
twsouthwick
force-pushed
the
tasou/session-null-values
branch
from
10655c9 to
a5b2ff4
Compare
Tratcher
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following to handle null values (including nullable structs):
Fixes #346