Skip to content

Add a message if a session value is wrong type #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Add a message if a session value is wrong type #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f256763
Add a message if a session value is wrong type
twsouthwick Apr 12, 2023
6a13881
fix test
twsouthwick Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/Services/SessionState/JsonSessionKeySerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ public JsonSessionKeySerializer(IOptions<JsonSessionSerializerOptions> options,
[LoggerMessage(0, LogLevel.Error, "Unexpected JSON serialize/deserialization error for '{Key}' expected type '{Type}'")]
private partial void LogException(Exception e, string key, string type);


[LoggerMessage(1, LogLevel.Warning, "Session key '{Key}' is registered as {RegisteredType} but was actually {FoundType}")]
private partial void UnexpectedType(string key, Type registeredType, Type foundType);

public bool TryDeserialize(string key, byte[] bytes, out object? obj)
{
if (_options.Value.KnownKeys.TryGetValue(key, out var type))
Expand All @@ -43,16 +47,23 @@ public bool TryDeserialize(string key, byte[] bytes, out object? obj)

public bool TrySerialize(string key, object value, out byte[] bytes)
{
if (_options.Value.KnownKeys.TryGetValue(key, out var type) && type == value.GetType())
if (_options.Value.KnownKeys.TryGetValue(key, out var type))
{
try
if (type == value.GetType())
{
bytes = JsonSerializer.SerializeToUtf8Bytes(value, type);
return true;
try
{
bytes = JsonSerializer.SerializeToUtf8Bytes(value, type);
return true;
}
catch (JsonException e)
{
LogException(e, key, type.Name);
}
}
catch (JsonException e)
else
{
LogException(e, key, type.Name);
UnexpectedType(key, type, value.GetType());
}
}

Expand Down