Skip to content

Fix for empty Authorization Header #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 17, 2023
Merged

Fix for empty Authorization Header #293

merged 4 commits into from
Feb 17, 2023

Conversation

@i4egod
Copy link
Contributor

@i4egod i4egod commented Feb 17, 2023

@dnfadmin
Copy link

dnfadmin commented Feb 17, 2023 •
edited
Loading

CLA assistant check
All CLA requirements met.

twsouthwick
twsouthwick requested changes Feb 17, 2023
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @4egod! Is there a test case you can add?

twsouthwick
twsouthwick reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more change and then it'll be good

@twsouthwick
Copy link
Member

twsouthwick commented Feb 17, 2023

Thanks @4egod for the submission! LGTM

@twsouthwick twsouthwick merged commit 9a256cb into dotnet:main Feb 17, 2023
@twsouthwick twsouthwick mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twsouthwick twsouthwick twsouthwick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@i4egod @dnfadmin @twsouthwick