Ensure default response headers are only set if empty #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
force-pushed
the
tasou/content-type-bug
branch
from
2661497 to
46ea97d
Compare
This change moves it to be on the `Response.OnStarting` call rather than at the beginning of the request. As part of this, a bug in `HttpRequest.AppendHeader` was fixed.
twsouthwick
force-pushed
the
tasou/content-type-bug
branch
from
46ea97d to
9069d19
Compare
Tratcher
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves it to be on the
Response.OnStartingcall rather than at the beginning of the request. As part of this, a bug inHttpRequest.AppendHeaderwas fixed.Fixes #203