Skip to content

Handle application paths for remote calls #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 2, 2022
Merged

Handle application paths for remote calls #192

merged 6 commits into from
Sep 2, 2022

Conversation

@twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Sep 2, 2022 •
edited
Loading

This change does two things:

  1. Ensures that the root address ends in a '/' and that the request path starts with a './'. This is done in a way that gets cached and won't be recomputed each request
  2. Update the RemoteModule to compare the incoming strings against the app relative path that accounts for any application paths or virtual directories.

Fixes #191

@twsouthwick
Handle application paths for remote calls
aa9a869 
This change does two things:

1) Add a DelegatingMessageHandler to ensure the app path is included on the request URI
2) Update the RemoteModule to compare the incoming strings against the app relative path that accounts for any application paths or virtual directories.

Fixes #191
@twsouthwick twsouthwick enabled auto-merge (squash) September 2, 2022 23:45
@twsouthwick twsouthwick merged commit 45f3049 into main Sep 2, 2022
@twsouthwick twsouthwick deleted the tasou/handle-virtual-directories-in-path branch September 2, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK left review comments

@Tratcher Tratcher Tratcher approved these changes

@mjrousos mjrousos Awaiting requested review from mjrousos

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remote authentication not working when Framework app is not the root of the website

4 participants

@twsouthwick @Tratcher @HaoK