Add recommended virtual directory setup to docs #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumbarros
suggested changes
Aug 26, 2022
There was a problem hiding this comment.
In docs/diagnostics.md
# Diagnostics
There is an initial system to help diagnose commone issues that can be opted into. Currently, this is only available on the ASP.NET Framework application
There is a typo, the correct is "commons" instead of "commone" right?
twsouthwick
force-pushed
the
tasou/add-diagnostics
branch
from
8252a48 to
afe96d6
Compare
twsouthwick
changed the title
|
Removing the diagnostic code for now in favor of going down a more generalized approach for health checks: #176 |
twsouthwick
force-pushed
the
tasou/add-diagnostics
branch
from
afe96d6 to
df24bac
Compare
|
@gumbarros good catch. I've updated the recommendation |
gumbarros
approved these changes
Aug 29, 2022
Tratcher
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual directories must be the same between the core and framework app. This may not be obvious to users as they get started, but a number of issues have been filed around this. This change adds some docs to guide people to this.
Fixes #174