Use reflection to set host header when forwarding #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
requested changes
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Outdated
Show resolved
Hide resolved
|
fyi - you're previous build failed in part due to using outdated vms. I have a PR #172 to fix that. |
twsouthwick
reviewed
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Show resolved
Hide resolved
twsouthwick
reviewed
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Outdated
Show resolved
Hide resolved
twsouthwick
reviewed
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Outdated
Show resolved
Hide resolved
twsouthwick
reviewed
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Show resolved
Hide resolved
twsouthwick
approved these changes
Aug 26, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/ProxyHeaderModule.cs
Outdated
Show resolved
Hide resolved
…roxyHeaderModule.cs Co-authored-by: Chris Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
Verified in debugger that the reflection codepath is not hit on normal requests to framework app, but is hit and updates the url correctly in the coreapp: