Add request feature to support buffered/bufferless streams #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
commented
Aug 24, 2022
| return _bufferedStream; | ||
| } | ||
|
|
||
| throw new InvalidOperationException("InputStream must be prebuffered"); |
Member
Author
There was a problem hiding this comment.
We could remove this requirement and provide an API similar to what is described in #164 for HttpRequest.GetInputStreamAsync() that would do the awaiting there. This then could block and wait with the recommendation people move to the async version
Member
Author
There was a problem hiding this comment.
For reference, this blocks on framework so is not a real change. Non-blocking APIs are the now available GetBufferedStream and GetBufferlessStream
HaoK
reviewed
Aug 25, 2022
src/Microsoft.AspNetCore.SystemWebAdapters/Adapters/IHttpRequestAdapterFeature.cs
Outdated
Show resolved
Hide resolved
HaoK
approved these changes
Aug 25, 2022
Tratcher
reviewed
Aug 26, 2022
|
|
||
| return body; | ||
| } | ||
| set => _other.Body = value; |
Member
There was a problem hiding this comment.
Should Mode be updated if the stream is replaced?
Member
Author
There was a problem hiding this comment.
I had thought about it, but wasn't sure how necessary it would be. Pushed a PR to reset in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150